Skip to content

Fix Linux CI dependency resolution on Ubuntu 24.04 (FreeRDP package names) - #2

Merged
Soar360 merged 2 commits into
copilot/refactor-rdpsdk-from-cxrdpbridgefrom
copilot/fix-compile-error
Jun 29, 2026
Merged

Fix Linux CI dependency resolution on Ubuntu 24.04 (FreeRDP package names)#2
Soar360 merged 2 commits into
copilot/refactor-rdpsdk-from-cxrdpbridgefrom
copilot/fix-compile-error

Conversation

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown

Linux CI was failing before compilation because the workflow referenced FreeRDP dev package names that do not exist on Ubuntu 24.04. This PR aligns dependency names with current Ubuntu package metadata and keeps docs consistent with CI.

  • Root cause addressed

    • Replaced invalid APT package libfreerdp3-dev with freerdp3-dev.
    • Removed libfreerdp-client3-dev from CI install list (not available on target runner image).
  • Workflow change

    • Updated /.github/workflows/build.yml Linux dependency install step to use valid FreeRDP 3 dev packages on ubuntu-24.04.
  • Documentation alignment

    • Updated Linux build instructions in /README.md to match the corrected dependency set used by CI.
# .github/workflows/build.yml (Linux deps)
sudo apt-get install -y \
  build-essential cmake ninja-build pkg-config \
  libssl-dev \
  freerdp3-dev libwinpr3-dev
Original prompt

Reference: https://github.com/coderbusy/rdp-bridge/actions/runs/28382608891/job/84089358776

修复编译失败

Copilot AI changed the title [WIP] Fix compilation failure Fix Linux CI dependency resolution on Ubuntu 24.04 (FreeRDP package names) Jun 29, 2026
Copilot AI requested a review from Soar360 June 29, 2026 15:59
@Soar360
Soar360 marked this pull request as ready for review June 29, 2026 16:23
Copilot AI review requested due to automatic review settings June 29, 2026 16:23
@Soar360
Soar360 merged commit 2040f73 into copilot/refactor-rdpsdk-from-cxrdpbridge Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Linux CI dependency installation on Ubuntu 24.04 by updating FreeRDP 3 APT package names to ones that actually exist on the runner image, and aligns the README Linux build instructions with CI.

Changes:

  • Update Linux CI dependencies to install freerdp3-dev + libwinpr3-dev (remove invalid libfreerdp3-dev and unavailable libfreerdp-client3-dev).
  • Update README Linux build instructions to match the corrected dependency list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
README.md Updates Linux build instructions to use freerdp3-dev instead of the non-existent libfreerdp3-dev on Ubuntu 24.04.
.github/workflows/build.yml Fixes Ubuntu 24.04 CI dependency install step by switching to valid FreeRDP 3 dev package names and removing an unavailable package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants